Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icarAttentionEventResource issue 393 #407

Merged
merged 7 commits into from
Nov 2, 2023

Conversation

cookeac
Copy link
Collaborator

@cookeac cookeac commented Aug 10, 2023

Add icarAttentionEventResource and associated enumerations.
TODO: Add to Example URL Scheme.
Resolves #393

Add icarAttentionEventResource and associated enumerations.
TODO: Add to Example URL Scheme.
Resolves adewg#393
@cookeac cookeac linked an issue Aug 10, 2023 that may be closed by this pull request
@cookeac cookeac changed the title Add icarAttentionEventResource Add icarAttentionEventResource issue 393 Aug 10, 2023
Copy link
Collaborator

@erwinspeybroeck erwinspeybroeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok for me

@cookeac cookeac closed this Sep 28, 2023
@cookeac cookeac deleted the 3933_Device_Attentions branch September 28, 2023 05:33
@cookeac cookeac restored the 3933_Device_Attentions branch October 17, 2023 01:19
@cookeac cookeac reopened this Oct 17, 2023
cookeac and others added 3 commits October 19, 2023 21:21
@cookeac
Copy link
Collaborator Author

cookeac commented Nov 2, 2023

I think this PR is now ready to go. It includes the changes from the recent technical group discussions, and now has APIs in exampleURLScheme and healthURLScheme OpenAPI specifications.

Copy link
Collaborator

@erwinspeybroeck erwinspeybroeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Copy link
Collaborator

@dirksieben dirksieben Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not use this one anymore, since we have the severity index now.
My earlier suggestion to include "Critical" here might be irrelevant. I suggest leaving "critical" out again, but it is not a deal breaker.

@cookeac cookeac merged commit 4b8a90e into adewg:Develop Nov 2, 2023
@cookeac cookeac deleted the 3933_Device_Attentions branch November 3, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device Attentions message
3 participants